This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] Fix 3 asm differences (issue4695048)
On Tue, Jul 12, 2011 at 3:25 PM, Diego Novillo <dnovillo@google.com> wrote:
> On 11-07-12 16:34 , Gabriel Charette wrote:
>
>> We probably want pph_register_decl_in_symtab to be inline as it does
>> so little now.
>
> It doesn't really matter all that much. ?Given that it's a static function,
> the compiler will inline it (or not) as an optimization. ?The 'inline'
> keyword is more and more just a suggestion than an actual guarantee.
>
OK
>> Now that you simply chainon bindings, you probably want to nreverse
>> them before you chain them on (this way we will stream them in from
>> first->last as this pacth does (to alloc stuff in order), but them in
>> the chain we want them to be last->first as they should be if they had
>> been pushed as they are in the original parser).
>
> Perhaps, but first I want to make sure we really want to reverse them all.
> ?Not every list is processed from back to front.
>
Ok, well for now in the code though they are inserted in the
current_bindings in the reverse order (names and namespaces for sure,
usings I'm not sure) then they were in the parser when originally
written out (I don't know if this causes problems...?)
Gab