This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pph] Add alternate addresses to register in the cache (issue4685054)

From: Diego Novillo <dnovillo at google dot com>
To: Gabriel Charette <gchare at google dot com>
Cc: reply at codereview dot appspotmail dot com, crowl at google dot com, gcc-patches at gcc dot gnu dot org
Date: Tue, 12 Jul 2011 14:30:15 -0400
Subject: Re: [pph] Add alternate addresses to register in the cache (issue4685054)
References: <20110711214228.4B2BB1DA197@topo.tor.corp.google.com> <CAJTZ7L+70DzAnh_Ym5EyX1XEKe6142-o7AsP1qNDFGAV_q8sKw@mail.gmail.com> <CAD_=9DTyoF8aXRw1kZ_EDtd_Cu+PrVD7UT8qwVhwKv9yV175TA@mail.gmail.com> <CAJTZ7LLo6-V6pvOu6LN-01Od4cWF4vHt0oBAzKiVoknScK0PFA@mail.gmail.com>

On Tue, Jul 12, 2011 at 14:23, Gabriel Charette <gchare@google.com> wrote:
> Right, I remember my original implementation had the same behaviour,
> but I'm pretty sure I had a comment mentioning that in the function
> usage comment. I'm just saying it should be mentioned what passing
> NULL means (especially since we do it all over the place).

Oh, absolutely.


Diego.

References:
- [pph] Add alternate addresses to register in the cache (issue4685054)
  - From: Diego Novillo
- Re: [pph] Add alternate addresses to register in the cache (issue4685054)
  - From: Diego Novillo
- Re: [pph] Add alternate addresses to register in the cache (issue4685054)
  - From: Gabriel Charette

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]