This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support -mx32 in GCC tests


On Thu, Jul 7, 2011 at 1:27 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Jul 7, 2011, at 11:26 AM, H.J. Lu wrote:
>> -/* { dg-do compile { target { { i?86-*-* rs6000-*-* alpha*-*-* x86_64-*-* } || { powerpc*-*-* && ilp32 } } } } */
>> +/* { dg-do compile { target { { i?86-*-* rs6000-*-* alpha*-*-* x86_64-*-* } || { powerpc*-*-* && ia32 } } } } */
>
> powerpc doesn't have an ia32 product?
>
> I think this shouldn't change?

Fixed.

>> -/* Disable the test entirely for 16-bit targets. ?*/
>> -#if __INT_MAX__ > 32767
>> +/* Disable the test entirely for 16-bit and x32 targets. ?*/
>> +#if __INT_MAX__ > 32767 && (!defined __x86_64__ || defined __LP64__)
>
> While not too important, might a dg-skip-if line be easier to read and understand?

Done.

>> -/* { dg-do compile { target { { { ! mips64 } && { ! ia64-*-* } } && { ! spu-*-* } } } } */
>> +/* { dg-do compile { target { { { { ! mips64 } && { ! ia64-*-* } } && { ! spu-*-* } } && { ! x32 } } } } */
>
>
> Hum, I worry about x86 walking away with large amounts of symbol space. ?Please change to x86 && x32 or x86_x32.

gcc.dg/lower-subreg-1.c tests long long using on ilp32 targets.  It
should be skipped on x32 similar to ia64, spu and mips.  I don''t
know how x86 && x32 or x86_x32 will help here.

>> -/* { dg-do compile } */
>> +/* { dg-do compile { target { x32 || lp64 } } } */
>
> Likewise.

gcc.dg/pr44194-1.c is tested if a target returns structures in register.
Can you tell me how I can enable it for x32?

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]