This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup
- From: Ian Lance Taylor <iant at google dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "gofrontend-dev\ at googlegroups dot com" <gofrontend-dev at googlegroups dot com>, Richard Henderson <rth at redhat dot com>
- Date: Wed, 06 Jul 2011 10:34:20 -0700
- Subject: Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup
- References: <AANLkTimxnJT+r0zh_Lyc7hOdXW1OUk4c0X8cM-61k=ix@mail.gmail.com> <yddoc4roghx.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <mcraag9lfya.fsf@google.com> <yddd3kxg9ek.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <mcroc3zyy12.fsf@google.com> <BANLkTikBR_LuPufmMvFxCVubqzAAA=RKaw@mail.gmail.com> <mcraae2pwsr.fsf@coign.corp.google.com> <BANLkTinS3wz9pK7GafDO72B3K4L-U5uu2A@mail.gmail.com> <mcrvcwplis8.fsf@coign.corp.google.com> <BE07C14A-5F78-44A3-B1EC-899D4B973C08@comcast.net> <mcr4o49jvch.fsf@coign.corp.google.com> <CAFULd4YC5669G1FDYOFY_HySV=a7-S8=E20bsFbDHKBiSwhNYw@mail.gmail.com> <21D4F683-7589-4562-8143-0A1A7805314C@comcast.net> <CAFULd4ZtyJasOWpB=zmrvb6BmVNy1yNxggx7yhSD9dYZFi=vdg@mail.gmail.com>
Uros Bizjak <ubizjak@gmail.com> writes:
> On Tue, Jul 5, 2011 at 7:17 PM, Mike Stump <mikestump@comcast.net> wrote:
>
>>> Please note that we set
>>> -mieee flag to compile .go files from library and also we add this
>>> flag to default testsuite compile flags.
>>
>>>
>> Ick, I think this patch might be expedient, but, wrong. ÂIan will have to think about it and decide.
>
> This is something I come up with after a lot of staring into build system:
>
> 2011-07-06 Uros Bizjak <ubizjak@gmail.com>
>
> * mt-alphaieee (GOCFLAGS_FOR_TARGET): Add -mieee.
>
> This patch by itself does not fix go testsuite failures, although the
> library is now OK. Additional patch is needed to pass GOCFLAGS to the
> compiler when checking the package. I will submit it separately.
>
> Tested on alphaev68-pc-linux-gnu. OK for mainline?
>
> Uros.
>
> Index: config/mt-alphaieee
> ===================================================================
> --- config/mt-alphaieee (revision 175904)
> +++ config/mt-alphaieee (working copy)
> @@ -1,2 +1,3 @@
> CFLAGS_FOR_TARGET += -mieee
> CXXFLAGS_FOR_TARGET += -mieee
> +GOCFLAGS_FOR_TARGET += -mieee
This seems like a reasonable patch to me, but technically speaking it is
incomplete. Go should have IEEE floating point behaviour by default. I
believe Java is the same. Ideally there would be a target-independent
way for a frontend to request this mode by default. It's a little bit
odd because as far as I know every other backend does default to proper
IEEE arithmetic, and only deviates when using -ffast-math or equivalent.
Anyhow, it's hard for me to care all that much about the Alpha, so I
will approve this patch. It's clearly better than the current
situation, and it follows what other languages are doing.
Thanks.
Ian