This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ICE with gfortran ... -L without argument (PR fortran/49623)
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 4 Jul 2011 21:13:58 +0200
- Subject: Re: [PATCH] Fix ICE with gfortran ... -L without argument (PR fortran/49623)
- References: <20110704172244.GS16443@tyan-ft48-01.lab.bos.redhat.com>
Dear Jakub,
Yes! OK for trunk and, if you will, for 4.6.
Thanks
Paul
On Mon, Jul 4, 2011 at 7:22 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> If -L doesn't have an argument, find_spec_file ICEs on it, as
> the argument is NULL. ?As suggested by Joseph, this disregards in
> this loop all options which don't have the required argument.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk/4.6?
>
> 2011-07-04 ?Jakub Jelinek ?<jakub@redhat.com>
>
> ? ? ? ?PR fortran/49623
> ? ? ? ?* gfortranspec.c (lang_specific_driver): Ignore options with
> ? ? ? ?CL_ERR_MISSING_ARG errors.
>
> --- gcc/fortran/gfortranspec.c.jj ? ? ? 2011-07-04 14:58:56.000000000 +0200
> +++ gcc/fortran/gfortranspec.c ?2011-07-04 15:01:58.000000000 +0200
> @@ -255,6 +255,9 @@ lang_specific_driver (struct cl_decoded_
>
> ? for (i = 1; i < argc; ++i)
> ? ? {
> + ? ? ?if (decoded_options[i].errors & CL_ERR_MISSING_ARG)
> + ? ? ? continue;
> +
> ? ? ? switch (decoded_options[i].opt_index)
> ? ? ? ?{
> ? ? ? ?case OPT_SPECIAL_input_file:
>
> ? ? ? ?Jakub
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
? ? ?? --Hitchhikers Guide to the Galaxy