This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Richard Henderson <rth at redhat dot com>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 01 Jul 2011 15:37:40 +0200
- Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
- References: <20110625161357.GA5401@intel.com> <4E078E58.20903@redhat.com> <BANLkTikToedVDqx9V+bB9xb+dL_r-6f31g@mail.gmail.com> <4E07A879.70509@redhat.com> <BANLkTik8ZOfWVUV7SV1ryQ=yJtUiCG+tqQ@mail.gmail.com> <4E089A88.60401@redhat.com> <BANLkTimw8O0UnnVATPKgrRCVT=82sO48Dw@mail.gmail.com> <4E0C8361.5050403@redhat.com> <BANLkTinOGKQCq2abZW0L7CLOQ901+Oodxg@mail.gmail.com> <4E0C904E.8090504@redhat.com> <BANLkTiknF6h_qJ9rAgBikdAM8O7RgSdyHA@mail.gmail.com> <BANLkTimGtPskWYsGOi+hp59DKnDW7wD2sw@mail.gmail.com> <BANLkTimYZoGBBUxq+uMehqGxR5E1cpEavA@mail.gmail.com> <yddvcvnxkm0.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTikRuXz1RP1LxU8BCEFoT+pNP5e_Jw@mail.gmail.com> <yddr56bxkb1.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTimRWq4S4bKQpvuYzO3Go6yMc2fcgg@mail.gmail.com> <4E0CC85E.3090401@redhat.com> <BANLkTimt9V4kyKE2jmixeMOW=k7ghWrw+A@mail.gmail.com> <yddaacyxtjd.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTi=1Y8wHj6Y_vMp5GJSp-C+yNVa5dw@mail.gmail.com>
"H.J. Lu" <hjl.tools@gmail.com> writes:
> On Fri, Jul 1, 2011 at 2:02 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>
>>> Here is the updated patch. ?It works on simple tests.
>>> I am running full tests. ?I kept config/i386/value-unwind.h
>>> since libgcc/md-unwind-support.h is included too late
>>> in unwind-dw2.c and I don't want to move it to be on
>>> the safe side.
>>
>> Oh please, don't pile hack upon hack to avoid proper testing.
>>
>
> What is your suggestion?
How about moving the md-unwind-support.h include up to the rest of the
includes? The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
helper macro, so order shouldn't matter.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University