This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] More C++ Tree Nodes (issue4526083)
- From: Lawrence Crowl <crowl at google dot com>
- To: crowl at google dot com, dnovillo at google dot com, froydnj at codesourcery dot com, gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com
- Date: Fri, 27 May 2011 10:57:43 -0700
- Subject: Re: [pph] More C++ Tree Nodes (issue4526083)
- References: <20cf303f68baea326404a441da76@google.com>
On 5/27/11, dnovillo@google.com <dnovillo@google.com> wrote:
>
> http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c
> File gcc/cp/cp-objcp-common.c (right):
>
> http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c#newcode103
> gcc/cp/cp-objcp-common.c:103:
> case TEMPLATE_INFO: return sizeof (struct
> tree_template_info);
>
> + case TREE_BINFO: return sizeof (struct tree_binfo);
> +
>
>
> TREE_BINFO is not a C++ code and it's variably-sized. It is already
> handled by tree.c:tree_size()
>
> Not sure why you needed to add this here?
It appears on of the other fixes in that patch fixed the issue,
so I will remove this change.
>
> http://codereview.appspot.com/4526083/
>
--
Lawrence Crowl