Re: Libiberty: POSIXify psignal definition

[Richard Earnshaw <rearnsha at arm dot com>]

On Tue, 2011-05-17 at 11:52 -0400, DJ Delorie wrote:
> > > 	* strsignal.c (psignal): Change second parameter to const char *.
> > > 	Fix comment accordingly.
> > > 
> > 
> > OK.
> 
> I had argued against this patch:
> 
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00439.html
> 
> The newlib change broke ALL released versions of gcc, and the above
> patch does NOT fix the problem, but merely hides it until the next
> time we trip over it.
> 

So regardless of whether the changes to newlib are a good idea or not, I
think the fix to libiberty is still right. Posix says that psignal takes
a const char *, and libiberty's implementation doesn't.  That's just
silly.

I do agree that the newlib code should be tightened up, particularly in
order to support older compilers; but that doesn't mean we shouldn't fix
libiberty as well.

R.