This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] Enable nested namespaces (issue4431071)
- From: dnovillo at google dot com
- To: crowl at google dot com
- Cc: gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com
- Date: Fri, 29 Apr 2011 22:23:06 +0000
- Subject: Re: [pph] Enable nested namespaces (issue4431071)
- Reply-to: crowl at google dot com, dnovillo at google dot com, gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com
Looks OK. Some comments below.
http://codereview.appspot.com/4431071/diff/1/gcc/c-family/c.opt
File gcc/c-family/c.opt (right):
http://codereview.appspot.com/4431071/diff/1/gcc/c-family/c.opt#newcode943
gcc/c-family/c.opt:943:
+fpph-dump-tree
+C++ Var(flag_pph_dump_tree)
+-fpph-dump-tree Dump global namespace tree around PPH reads/writes.
+
We should just add to the existing -fdump-translation-unit. Maybe not
so important now.
http://codereview.appspot.com/4431071/diff/1/gcc/cp/name-lookup.c
File gcc/cp/name-lookup.c (right):
http://codereview.appspot.com/4431071/diff/1/gcc/cp/name-lookup.c#newcode1186
gcc/cp/name-lookup.c:1186: {
+tree
+pushdecl_into_namespace (tree dcl, tree nsp)
+{
Needs comment.
http://codereview.appspot.com/4431071/