This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix up hot/cold partitioning on ports that don't have long conditional branches


Ping?

On Apr 22, 2011, at 3:01 PM, Mike Stump wrote:
> On Apr 22, 2011, at 3:28 AM, Eric Botcazou wrote:
>>> This patch fixes up hot/cold partitioning on ports that don't have long
>>> conditional branches.  I'll note that the entire file has lots of other
>>> jump optimizations that are suspect.
>> 
>> Do you have a testcase for one of the ports in the tree?
> 
> Nope.  Found via an out of tree port with tree-prof.exp=pr34999.c.
> 
>> Note that parameters of function must be documented in the head comment.
> 
> Fixed.
> 
>> The patch contains long lines.
> 
> Didn't know we had switched over to caring that much.  Want me to fix all of gcc/*.[ch]?
> 
>> The ChangeLog entry doesn't look correct (relax_delay_slots mentioned 
>> twice, no mention of the new parameter of follow_jumps, etc).
> 
> Fixed.
> 
>> How was the patch tested?
> 
> make check-gcc.
> 
>> Please generate patches with diff -p.
> 
> Done.
> 
> 
> Ok?


Attachment: reorg-cold-jumps.diffs.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]