This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] FIx PR47647, revert an earlier patch
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>
- Date: Sun, 24 Apr 2011 21:18:45 -0700
- Subject: Re: [PATCH] FIx PR47647, revert an earlier patch
- References: <alpine.LNX.2.00.1102181717090.17230@zhemvz.fhfr.qr> <AANLkTimjTvRXyNN1uycHBS=geu7pBW-DCC_xyraZBZSS@mail.gmail.com>
On Sat, Feb 19, 2011 at 4:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Feb 18, 2011 at 8:19 AM, Richard Guenther <rguenther@suse.de> wrote:
>>
>> This reverts lazy BLOCK_VARS streaming as I thought back in time
>> that VAR_DECLs have BLOCKs as DECL_CONTEXT while they have
>> FUNCTION_DECLs ... so the patch doesn't work at all and instead
>> causes us to not stream in any BLOCKs, resulting in no local
>> decls at all in debug info. ?Not good.
>>
>> Fixed with the following which also makes latent guality issues
>> re-appear - they were hidden by
>>
>> pr41353-1.gdb:3: Error in sourced command file:^M
>> No symbol "vari2" in current context.^M
>> UNSUPPORTED: gcc.dg/guality/pr41353-1.c ?-O2 -flto -flto-partition=none
>> line 17 vari2 == 3 * 17
>>
>> where "No symbol "vari2" in current context" isn't treated the
>> same as "<optimized out>" ...
>>
>> I have filed bugs for some LTO debug info issues I noticed.
>>
>> Bootstrapped and tested on x86_64-unknown-linux-gnu, ok?
>>
>> Thanks,
>> Richard.
>>
>> 2011-02-18 ?Richard Guenther ?<rguenther@suse.de>
>>
>> ? ? ? ?PR lto/47647
>> ? ? ? ?* lto-streamer-in.c (lto_input_ts_decl_minimal_tree_pointers):
>> ? ? ? ?Remove lazy BLOCK_VARS streaming.
>> ? ? ? ?(lto_input_ts_block_tree_pointers): Likewise.
>> ? ? ? ?* lto-streamer-out.c (lto_output_ts_block_tree_pointers): Likewise.
>>
>
> This may have caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47820
>
This also caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48354
--
H.J.