This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix WPA corruption seen in LTO bootstrap
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 24 Apr 2011 12:44:08 +0200
- Subject: Re: Fix WPA corruption seen in LTO bootstrap
- References: <20110424013357.GF27564@kam.mff.cuni.cz>
> Hi,
> the problems with LTO build reported by Toon is caused by a hack disabling
> jump function in ipa-prop on wpa. The hack is no longer needed and it is wrong,
> since jump function makes no sense when they are not updated. Consequentely
> inline cost metrics get lost.
>
> I am testing the following patch that also fortifies the datastructures
> for array overruns (this was how the problem manifested itself).
>
> Bootstrapping/regtesting x86_64-linux, will commit it if passes.
>
> Honza
>
> * ipa-prop.c (ipa_propagate_indirect_call_infos): Remove obsolette
> WPA hack.
Martin,
since indirect inlining at WPA time is enabled for 4.6, I think it is just matter
of testcase showing that the fix is needed for 4.6, too (i.e. arrange function A
to be inlined to B that passes through callback but use different formal ID to do so.)
Honza