This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.
2011/4/20 Georg-Johann Lay <avr@gjlay.de>:
> Denis Chertykov schrieb:
>> 2011/4/17 Denis Chertykov <chertykov@gmail.com>:
>>> 2011/4/15 Georg-Johann Lay <avr@gjlay.de>:
>>>> Finally, I exposed alternative #3 of the insns to the register
>>>> allocator, because it is not possible to distinguish between
>>>> overlapping or non-overlapping regs, and #3 does not need a scratch.
>>>>
>>>> Ran C-testsuite with no regressions.
>>> Are you encountered any difference in code size ?
>>
>> I'm ask about code size because the IRA pass isn't work with
>> `scratch:MODE' at all.
>> This lead to bad/wrong register allocation in IRA pass.
>> The reload pass will correct such a wrong allocation, but reload can't
>> generate optimal code. (reload generate correct code).
>> Because of that, may be you right and may be better to have
>> (clobber (match_operand....)) instead of (clobber (match_scratch...)).
>
> So the conclusion is not to commit this patch and that the one-liner
> already installed is sufficient to fix the ICE?
Yes.
Denis.