This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Add makefile for cross-configuration torture test


Hi Joern,

* Joern Rennecke wrote on Wed, Apr 13, 2011 at 11:02:27PM CEST:
> 2010-04-13  Joern Rennecke  <joern.rennecke@embecosm.com>
> 
>         * config-list.mk: New file.

> --- contrib/config-list.mk	(revision 0)
> +++ contrib/config-list.mk	(revision 0)

> +all: $(LIST)
> +
> +.PHONEY: make-log-dir make-script-dir

.PHONEY is phony, it should be .PHONY instead.  SCNR.

> +empty=
> +
> +#Check for the presence of the MAINTAINERS file to make sure we are in a
> +#suitable current working direcrory.

directory.

> +make-log-dir: ../gcc/MAINTAINERS
> +	mkdir log
> +
> +# The 'ix86-netware --with-ld=nwld' configuration needs a nwld executable to
> +# configure.  See PR47104.
> +make-script-dir:
> +	mkdir scripts
> +	echo ld $* > scripts/nwld
> +	chmod u+x scripts/nwld
> +
> +$(LIST): make-log-dir make-script-dir
> +	-mkdir $@
> +	(cd $@ && \
> +	../../gcc/configure \
> +	--target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
> +	--enable-werror-always ${host_options} --enable-languages=all,ada,go) \
> +	> log/$@-config.out 2>&1
> +	-$(MAKE) -C $@ all-gcc > log/$@-make.out 2>&1 && rm -r $@

Can you separate the configure and the build steps into separate make
targets so that one can run one but not the other?  Or would that have
adverse effects on the load pattern (it might, due to the way make
orders scheduling of jobs)?  Would be nice to have 'all-gcc' abstracted
into a make variable too, so it could be reused for other purposes.
Please use rm -rf instead of rm -r.

Thank you!
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]