This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] Fix PR46399 - missing mode promotion for libcall args
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
- Date: Wed, 13 Apr 2011 15:59:01 +0200
- Subject: Re: [PING] Fix PR46399 - missing mode promotion for libcall args
- References: <20110413105432.GA5425@bart> <m3pqoq8ei2.fsf@pepe.airs.com>
On 04/13/2011 03:31 PM, Ian Lance Taylor wrote:
> "Andreas Krebbel" <krebbel@linux.vnet.ibm.com> writes:
>
>> This fixes a wrong code generation bug for sw DFP:
>>
>> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00141.html
>
> Why do we need a new target hook just for libcalls? Why not just use
> the existing TARGET_PROMOTE_FUNCTION_MODE hook? We could say that for a
> libcall functype is passed as NULL. Only the SH cares about the
> function type at all, and it is already prepared to handle NULL.
But in order to preserve current behaviour all targets defining the hook then would have
to be modified not to do any promotions if funtype is NULL. As I understand it a target
usually does not want the normal promotions for libcalls since libcalls follow their own ABI.
-Andreas-