This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add debugging functions for cp_parser (issue4389045)
- From: Diego Novillo <dnovillo at google dot com>
- To: dnovillo at google dot com, crowl at google dot com, jason at redhat dot com, gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com
- Date: Tue, 12 Apr 2011 20:53:21 -0400
- Subject: Re: Add debugging functions for cp_parser (issue4389045)
- References: <20cf30334cafd09df704a0c184b3@google.com>
On Tue, Apr 12, 2011 at 20:02, <crowl@google.com> wrote:
> One oddity, otherwise LGTM.
>
>
> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c
> File gcc/cp/parser.c (right):
>
> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375
> gcc/cp/parser.c:375: if (flag)
> This code will never print "false", so why have it?
Thanks. I originally had it printing true and false values. I then
changed my mind (too noisy, as most fields are false) but forgot to
change it. I'll fix.
Diego.