This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] Remove kludge in commit_edge_insertions
On Wed, Apr 6, 2011 at 8:37 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Wed, Apr 6, 2011 at 8:15 PM, Jeff Law <law@redhat.com> wrote:
>
>>> AFAIU the patch doesn't change behavior for the GIMPLE CFG. It only affects RTL.
>> But the elimination of the PHI results in creating RTL that is inserted
>> on a CFG edge.
>
> Yes, but gimple_expand_cfg() calls find_many_sub_basic_blocks(), and
> that should be enough, no??
>
> /me goes back to trying to understand this code :-)
Could you please add an explanation to the PR about how that PHI
results in a loop on an edge? My fantasy is not big enough to
visualize any case where that can happen!
Ciao!
Steven