This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR43920, 3/9] Cleanup.
- From: Tom de Vries <vries at codesourcery dot com>
- To: gcc-patches at gcc dot gnu dot org, ebotcazou at libertysurf dot fr
- Cc: Maxim Kuvyrkov <maxim at codesourcery dot com>, Bernd Schmidt <bernds at codesourcery dot com>
- Date: Fri, 01 Apr 2011 17:15:19 +0200
- Subject: Re: [PATCH, PR43920, 3/9] Cleanup.
- References: <4D94C603.7080505@codesourcery.com> <4D94C80C.10100@codesourcery.com> <4D95E5A7.7090201@codesourcery.com>
On 04/01/2011 05:01 PM, Jakub Jelinek wrote:
> On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote:
>> Reposting, with ChangeLog.
>
> Similarly one of your patches had
> * gcc/cfgcleanup.c (whatever): Whatever.
> in the ChangeLog, should be just
> * cfgcleanup.c (whatever): Whatever.
>
> Jakub
Fixed ChangeLog.
Thanks,
- Tom
2011-04-01 Tom de Vries <tom@codesourcery.com>
PR target/43920
* cfgcleanup.c (try_crossjump_bb): Remove 2 superfluous variables.
diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c
--- gcc/cfgcleanup.c (working copy)
+++ gcc/cfgcleanup.c (working copy)
@@ -1961,7 +1961,6 @@
edge e, e2, fallthru;
bool changed;
unsigned max, ix, ix2;
- basic_block ev, ev2;
/* Nothing to do if there is not at least two incoming edges. */
if (EDGE_COUNT (bb->preds) < 2)
@@ -2001,9 +2000,9 @@
fallthru = find_fallthru_edge (bb->preds);
changed = false;
- for (ix = 0, ev = bb; ix < EDGE_COUNT (ev->preds); )
+ for (ix = 0; ix < EDGE_COUNT (bb->preds);)
{
- e = EDGE_PRED (ev, ix);
+ e = EDGE_PRED (bb, ix);
ix++;
/* As noted above, first try with the fallthru predecessor (or, a
@@ -2021,7 +2020,6 @@
{
changed = true;
ix = 0;
- ev = bb;
continue;
}
}
@@ -2045,10 +2043,9 @@
if (EDGE_SUCC (e->src, 0) != e)
continue;
- for (ix2 = 0, ev2 = bb; ix2 < EDGE_COUNT (ev2->preds); )
+ for (ix2 = 0; ix2 < EDGE_COUNT (bb->preds); ix2++)
{
- e2 = EDGE_PRED (ev2, ix2);
- ix2++;
+ e2 = EDGE_PRED (bb, ix2);
if (e2 == e)
continue;
@@ -2071,7 +2068,6 @@
if (try_crossjump_to_edge (mode, e, e2))
{
changed = true;
- ev2 = bb;
ix = 0;
break;
}