This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fix for 48208 and 48260 on darwin
- From: Mike Stump <mikestump at comcast dot net>
- To: Christian Schüler <gcchelp dot 5 dot adept at 0sg dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 28 Mar 2011 10:58:33 -0700
- Subject: Re: fix for 48208 and 48260 on darwin
- References: <loom.20110328T054514-37@post.gmane.org>
On Mar 27, 2011, at 8:55 PM, Christian Schüler wrote:
> please review the following patch (and besides, bear with me as this is the
> first patch proposal from me). For gcc 4.5 and earlier it was possible to
> configure xcode via a modified xcplugin to use the newer gcc directly (yes,
> the -arch flag was ignored during link time, but since I had -m32/-m64
> anyways, this didn't matter). With the new argument checking of version 4.6
> during the linking stage this is no longer possible. The proposed patch makes
> gcc on darwin recognize the -arch flag to the extent necessary to reinstate
> the old functionality. Besides, it fixes the already existing support for the
> -F flag.
Ok (when regression tested). Did you run the gcc regression testsuite on it? To install it, we'd need a testsuite run on it. Roughy, run the testsuite before your patch, save off the .sum file, run it after your patch, then run contrib/compare_tests before.sum after.sum and see if there is any output. You might need expect/tcl/dejagnu installed to do that.
If you want to contribute longer term (larger patches), you'll want to get started on your paper work, if you've not done that already. And, welcome. Before you say, but... let me say, what took so long, 10 years is a long while? :-)