This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Better .debug_aranges fix (PR debug/48253, take 3)


On 03/25/2011 01:01 PM, Jakub Jelinek wrote:
+	    if (node == loc_list->last_before_switch
+		&& (node != loc_list->first || loc_list->first->next)
+		&& current_function_decl)

Let's store this test in a local variable rather than repeat it a few lines down.


+  if (fde->dw_fde_second_begin && fde->dw_fde_switch_cfi == NULL)
+    start_label = fde->dw_fde_second_begin;

Can this happen? If we haven't switched, second_begin should be null.


Otherwise, looks good.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]