This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011/3/25 Jason Merrill <jason@redhat.com>:
> On 03/24/2011 08:44 PM, Kai Tietz wrote:
>>
>> +static bool
>> +attribute_value_equal (const_tree attr1, const_tree attr2)
>> +{
>> + ?if (attr1 == attr2)
>> + ? ?return true;
>
> I still think this test should be comparing TREE_VALUEs.
>
> Jason
>

Ok, it makes sense to check here for value indentity instead of
identity of list-node. Thanks. Updated patch attached.

Kai

Attachment: comp_type_attributes.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]