This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/23/11 08:25, Jeff Law wrote: > On 03/21/11 11:50, Jakub Jelinek wrote: >> On Mon, Mar 21, 2011 at 11:37:16AM -0600, Jeff Law wrote: >>> Similarly for redirect_edge_succ_nodup in this fragment: >>> >>> ret = redirect_edge_succ_nodup (e, dest); >>> if (dump_file) >>> fprintf (dump_file, "Fallthru edge %i->%i redirected to %i\n", >>> e->src->index, e->dest->index, dest->index); >>> } >>> Luckily in this case the use-after-free only occurs when dumping, so it >>> won't typically affect end users. > >> Well, the message is wrong anyway, becase e->dest->index will be >> dest->index (with the exception that e has been remove_edge, but then it is >> the use after free). Guess the message should be printed before the >> redirect_edge_succ_nodup call, or remember e->dest->index in some local >> variable and print that variable after the call. > Yea, I'll just move the message before the call to > redirecT_edge_succ_nodup. Attached is the actual patch that was checked in after another bootstrap and regression test. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNii+4AAoJEBRtltQi2kC7aLsIAJQ8JrBCCCSNC0HH+1NgAdyp aUFEpQJUV9KgYpKzcqtKY5+kJI4WXRnRXsMmXuC4rWKV5rsnGmCzOSoHolHecLXB F7J3KaCwg51tcJ/wxXUCPUy+MhZ/ZWHBVbLzw+aQ+O4mXqwnHoRRxnUwGmas6rDk +pFXjmTArphMQdQ/xnOtXqUylecf4iu06Axn+0UXVy2J3CHT3jPvjuNZUHVUcVq+ qNrUTwYhDMHPXQtZWGz4RNqoACmpY/ku53xXwJq4PrcD1g/rl8Vy6aVnTPE9lONv rXmxr/FgNFZixKxNhaYz6A+maXbM4uRGZvSoGuO0do/YulZXXN+Ym5HHlocM/pQ= =/fA+ -----END PGP SIGNATURE-----
Attachment:
patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |