This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 4.7 deprecated targets removal patch


Hello Joseph,

* Joseph S. Myers wrote on Fri, Mar 18, 2011 at 12:12:09PM CET:
> Bootstrapped with no regressions on x86_64-unknown-linux-gnu.  OK to
> commit?

The build system changes look OK from a build system technical POV,
with a couple of comments below.

> 2011-03-17  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* MAINTAINERS (crx port, m68hc11 port): Remove.  Move maintainers
> 	to Write After Approval.
> 	* config-ml.in: Don't handle arc-*-elf*.
> 	* configure.ac (arc-*-*, crx-*-*, i[[3456789]]86-*-pe,
> 	m68hc11-*-*|m6811-*-*|m68hc12-*-*|m6812-*-*, mcore-*-pe*): Don't
> 	handle GCC libraries.
> 	* configure: Regenerate.
[...]

> --- config-ml.in	(revision 171107)
> +++ config-ml.in	(working copy)

I'll merge this change to Automake in your name, once you've committed
it to GCC and src.

> @@ -2,7 +2,7 @@
>  # wanting multilib support.
>  #
>  # Copyright (C) 1995, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
> -# 2005, 2006, 2007, 2008, 2010  Free Software Foundation, Inc.
> +# 2005, 2006, 2007, 2008, 2010, 2011  Free Software Foundation, Inc.
>  #
>  # This file is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -224,19 +224,6 @@ done
>  # $host here, not $target.
>  
>  case "${host}" in
> -arc-*-elf*)
> -	if [ x$enable_biendian != xyes ]
> -	then
> -	  old_multidirs=${multidirs}
> -	  multidirs=""
> -	  for x in ${old_multidirs}; do
> -	    case "${x}" in
> -	      *be*) : ;;
> -	      *) multidirs="${multidirs} ${x}" ;;
> -	    esac
> -	  done
> -	fi
> -	;;
>  arm-*-*)
>  	if [ x"$enable_fpu" = xno ]
>  	then

> --- configure.ac	(revision 171107)
> +++ configure.ac	(working copy)
> @@ -670,7 +670,7 @@ case "${target}" in
>      libgloss_dir=wince
>      ;;
>    arc-*-*)
> -    noconfigdirs="$noconfigdirs target-libgloss ${libgcj}"
> +    noconfigdirs="$noconfigdirs target-libgloss"
>      ;;
>    arm-semi-aof )
>      ;;
> @@ -744,7 +744,6 @@ case "${target}" in
>      libgloss_dir=cris
>      ;;
>    crx-*-*)
> -    noconfigdirs="$noconfigdirs target-libstdc++-v3 target-mudflap ${libgcj}"
>      ;;

Why not also remove the line before and after this one?
Is that because crx is still supported in binutils or other
src projects?  If yes, the hunk is fine, but then I wonder
whether it is too early to drop the config-ml.in bits for src.

>    d10v-*-*)
>      noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj}"
> @@ -862,7 +861,7 @@ case "${target}" in
>    i[[3456789]]86-*-uwin* | i[[3456789]]86-*-interix* )
>      ;;
>    i[[3456789]]86-*-pe)
> -    noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj}"
> +    noconfigdirs="$noconfigdirs target-libgloss"
>      ;;
>    i[[3456789]]86-*-sco3.2v5*)
>      # The linker does not yet know about weak symbols in COFF,
> @@ -888,7 +887,7 @@ case "${target}" in
>      noconfigdirs="$noconfigdirs ${libgcj}"
>      ;;
>    m68hc11-*-*|m6811-*-*|m68hc12-*-*|m6812-*-*)
> -    noconfigdirs="$noconfigdirs target-libiberty target-libstdc++-v3 ${libgcj}"
> +    noconfigdirs="$noconfigdirs target-libiberty"
>      libgloss_dir=m68hc11
>      ;;
>    m68k-*-elf*)
> @@ -901,9 +900,6 @@ case "${target}" in
>      libgloss_dir=m68k
>      ;;
>    mcore-*-pe*)
> -  # The EPOC C++ environment does not support exceptions or rtti,
> -  # and so building libstdc++-v3 tends not to always work.
> -    noconfigdirs="$noconfigdirs target-libstdc++-v3"
>      ;;

Likewise.

>    mmix-*-*)
>      noconfigdirs="$noconfigdirs target-libffi target-boehm-gc gdb libgloss"

Thanks,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]