This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler
On Thu, 10 Mar 2011, Nathan Froyd wrote:
> This patch does lose location information on CASE_LABEL_EXPRs from the C
> family of front-ends; it did not seem worth it to have a number of
> places pass input_location when said information isn't even used. I'm
> happy to add the location_t argument back to CASE_LABEL_EXPRs if people
> think that's worthwhile.
Since implicit use of input_location is deprecated and should be being
phased out (making more locations explicit - including explicit
input_location until the places using it have a better location
available), I think you should keep the location argument.
The C front-end changes in this patch series (including c-family changes)
are otherwise OK.
--
Joseph S. Myers
joseph@codesourcery.com