This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH, 4.6] Do not create new cgraph noes in the verifier
- From: Martin Jambor <mjambor at suse dot cz>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Guenther <rguenther at suse dot de>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 11 Mar 2011 10:43:24 +0100
- Subject: [PATCH, 4.6] Do not create new cgraph noes in the verifier
Hi,
while working on removing lazy cgraph node creation I have noticed
that we might do that even in the call graph verifier which certainly
looks undesirable. Richi pre-approved removing it on IRC but I am not
sure whether that was for 4.6. On the other hand I guess the change
is rather obvious and the verifier is disabled with release checking
and so I'd prefer to commit it now. Is it OK?
Bootstrapped and tested on x86_63-linux without any problems.
Thanks,
Martin
2011-03-10 Martin Jambor <mjambor@suse.cz>
* cgraphunit.c (verify_cgraph_node): Call cgraph_get_node instead of
cgraph_node.
Index: src/gcc/cgraphunit.c
===================================================================
--- src.orig/gcc/cgraphunit.c
+++ src/gcc/cgraphunit.c
@@ -551,7 +551,7 @@ verify_cgraph_node (struct cgraph_node *
error_found = true;
}
- if (!cgraph_node (node->decl))
+ if (!cgraph_get_node (node->decl))
{
error ("node not found in cgraph_hash");
error_found = true;