This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: Johannes Singler <singler at kit dot edu>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
Date: Thu, 10 Mar 2011 16:31:40 +0000
Subject: Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator
References: <4D789E41.6020903@kit.edu> <AANLkTiku2w_=Na3XLLgYf6e5yYvisbmQJirLhHn4ZRVk@mail.gmail.com> <4D78E81B.6010807@kit.edu>

On 10 March 2011 15:02, Johannes Singler wrote:
>
> Well, isn't it a bit ugly to define such a guard newly every time?

It's one of my favourite techniques, the type is local and has no
linkage, it should be nothing but a destructor call which is
guaranteed to happen when exiting that scope.

> In other places, parallel mode uses std::vector, but I guess this is
> actually also discouraged for internal use, since it adds the <vector>
> dependency.

I don't have a strong feeling either way - for this case where the
resource is just memory, std::vector would work fine.

The local RAII type is more useful when you have other resources to
clean up which need custom handling.

References:
- [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator
  - From: Johannes Singler
- Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator
  - From: Jonathan Wakely
- Re: [PATCH][libstdc++-v3 parallel mode] Avoid taking address of dereferenced random access iterator
  - From: Johannes Singler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]