This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS
- From: Ian Lance Taylor <iant at google dot com>
- To: gcc-patches at gcc dot gnu dot org, gofrontend-dev at googlegroups dot com
- Cc: ro at CeBiTec dot Uni-Bielefeld dot DE
- Date: Tue, 08 Mar 2011 21:57:13 -0800
- Subject: libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS
This patch to libgo only runs the networking dependent tests if
GCCGO_RUN_ALL_TESTS is set in the environment. This is PR 48017. In
that PR Rainer suggests having the tests drop back to UNSUPPORTED or
UNRESOLVED if they fail to open a network connection. That is tempting
but I don't agree with it, because it means that the tests will never
fail. It might be better to have some way to test whether the network
is available and usable before running the tests. However, that is in
itself problematic, as people running all the gcc tests don't
necessarily want their machine to start opening network connections. So
I think the compromise of requiring an environment variable works well.
Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.
Committed to mainline.
Ian
diff -r 49a9a1dcc2e8 libgo/Makefile.am
--- a/libgo/Makefile.am Tue Mar 08 21:28:00 2011 -0800
+++ b/libgo/Makefile.am Tue Mar 08 21:51:48 2011 -0800
@@ -2952,13 +2952,13 @@
fmt/check \
gob/check \
html/check \
- http/check \
+ $(if $(GCCGO_RUN_ALL_TESTS),http/check) \
io/check \
json/check \
log/check \
math/check \
mime/check \
- net/check \
+ $(if $(GCCGO_RUN_ALL_TESTS),net/check) \
netchan/check \
os/check \
patch/check \
@@ -2974,7 +2974,7 @@
strconv/check \
strings/check \
sync/check \
- syslog/check \
+ $(if $(GCCGO_RUN_ALL_TESTS),syslog/check) \
tabwriter/check \
template/check \
time/check \