This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)
- From: Diego Novillo <dnovillo at google dot com>
- To: gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com, ro at cebitec dot uni-bielefeld dot de, mikestump at comcast dot net, Simon Baldwin <simonb at google dot com>
- Date: Fri, 4 Mar 2011 13:50:50 -0800
- Subject: Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)
- References: <20110304214837.06A58AE1C6@tobiano.tor.corp.google.com>
On Fri, Mar 4, 2011 at 13:48, Diego Novillo <dnovillo@google.com> wrote:
>
> When running tests in a toolchain configure --with-build-sysroot, we
> need to execute the testsuite pointing every compiler invocation to
> the build sysroot (which in our case is different than the sysroot
> that the compiler is configured with).
>
> This patch adds a new global variable TEST_SYSROOT that takes its
> value from SYSROOT_CFLAGS_FOR_TARGET.
>
> Mike, Rainer, is this approach OK? ÂI had started by setting
> TOOL_OPTIONS, but that confused libgloss.exp when it tried to compute
> multilibs (get_multilibs). ÂThe presence of the argument
> --sysroot=.... causes get_multilibs to call gcc with
> --print-multilibs, which returns the string '.'. ÂThis causes massive
> failures on all the tests that run with non-default multilibs.
>
> I'm applying this on google/integration. ÂOK for 4.7? (the patch for
> trunk would be slightly different, but the idea is the same).
I forgot to add. Simon, this still shows up some failures in
google/integration, but these failures are the same we have in trunk.
For our builds, we have been XFAILing these failures, right? Do you
want me to mark them XFAIL to avoid problems with the auto builds?
Diego.