This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch libgfortran]: Fix build of libgfortran for mingw and improve POSIX ctime_r implementation
On Sat, Jan 29, 2011 at 20:46, Daniel Franke <franke.daniel@gmail.com> wrote:
> On Saturday 29 January 2011 18:20:55 Kai Tietz wrote:
> [...]
>> >> Âctime_r (const time_t * timep, char * buf __attribute__((unused)))
> [...]
>> >> + Â Âtmp = strcpy (buf, tmp);
> [...]
>> Applied at revision 169389.
>
> You may want to remove the "__attribute_((unused))" on "buf" as well?
That would cause a warning on targets without ctime() (the #else branch).
That being said, what are the things we can actually assume without
testing for it and having fallbacks? Things like ctime() and time()
are C89, do we really support any targets where those are not
available?
--
Janne Blomqvist