This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed] Add __float128 type support to hppa-hpux
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: dave dot anglin at nrc-cnrc dot gc dot ca, gcc-patches at gcc dot gnu dot org
- Date: Wed, 26 Jan 2011 01:19:43 +0000 (UTC)
- Subject: Re: [committed] Add __float128 type support to hppa-hpux
- References: <20110125233938.8071A4E33@hiauly1.hia.nrc.ca>
On Tue, 25 Jan 2011, John David Anglin wrote:
> >
> > On Tue, 18 Jan 2011, John David Anglin wrote:
> >
> > > + /* TFmode support builtins. */
> > > + ftype = build_function_type_list (long_double_type_node,
> > > + long_double_type_node,
> > > + NULL_TREE);
> > > + decl = add_builtin_function ("__builtin_fabsq", ftype,
> > > + PA_BUILTIN_FABSQ, BUILT_IN_MD,
> > > + "_U_Qfabs", NULL_TREE);
> >
> > Adding these built-in functions is not appropriate. The correct model for
> > __float128 as an alias for long double is IA64 HP-UX, where these
> > functions are not provided, or __float80 on x86, where again no special
> > functions are needed or provided.
>
> "_U_Qfabs" is provided by HP on PA-RISC.
I don't see how that relates to my comment. The existence of some
function in HP's libraries is independent of the uselessness of a built-in
function that just duplicates __builtin_fabsl; my point is that no such
duplicative built-in function should be added.
If your issue is that __builtin_fabsl falls back to a fabsl function that
doesn't exist or doesn't work, and should be falling back to _U_Qfabs, you
should fix that problem with __builtin_fabsl rather than adding a new
function.
--
Joseph S. Myers
joseph@codesourcery.com