This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ada, testsuite] gnat.dg cleanup


Arnaud Charlet <charlet@adacore.com> writes:

[Please keep me on the Cc:; it's easier for me not to overlook responses.]

>> Ok for mainline?
>
> Sounds like you're introducing a heavy mechanism with a maintenance burden
> for each new test.
>
> We do not want to have to put an extra
>
> -- { dg-final { cleanup-packages "Aggr16_Pkg" } }
>
> at the end of almost each test: this should be done automatically IMO.
>
> In other words, all tests that compile files will generate .ali and .o file,
> so the clean up should be automatic/implicit rather than explicit, otherwise
> new tests will suffer from the same issues.

This is not for every test, but only for those that use other packages.
For all others, it's already automatic.  Like you, I'd consider anything
else inappropriate.

I don't know if it's easy to deduce the list of used packages inside the
testsuite framework.  At the moment, this annotation is only necessary
for 58 out of 840 files in gnat.dg, which I wouldn't consider too heavy
a burden on the maintainers.  In fact, it took me quite some time to get
the lists right, especially in gnat.dg/specs.

If you have suggestions on how to automate this, I'd be happy to listen.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]