This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR debug/46931] don't crash propagating removed DEFs into debug stmts
On Tue, Dec 28, 2010 at 9:26 PM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Dec 26, 2010, Richard Guenther <richard.guenther@gmail.com> wrote:
>
>> Yeah. ?But wasn't there a correctness problem with propagating as well?
>
>> the the debug info will refer to the wrong value of i. ?Remember that
>> we can have overlapping life ranges for SSA names but not for the
>> decls for which we emit debug info.
>
> The value expressions in debug stmts refer to the SSA names, so there's
> no problem, at least in this regard. ?The overlapping ranges, if
> expanded to different pseudos, it will get the correct RTL expressions;
> if no longer available at a point, it should not get any RTL expression
> (although it would in theory be possible to do better, looking for some
> equivalence).
>
> Now, I don't think the latter has been actually verified, especially
> after the change that made us go straight from SSA to RTL, so if you
> have evidence that we're doing it wrong, I'd love to see it.
I don't have evidence, it's just what I seem to remember (for some
reason). Btw, we can have memory operands on the RHS of debug
stmts? For those propagating wouldn't be valid as they are not
in SSA form.
Richard.
>>> Regstrapping your proposed patch now.
>
>> It's ok to commit if it works (with your testcase).
>
> Here's what I installed.
>
>
>
> --
> Alexandre Oliva, freedom fighter ? ?http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/ ? FSF Latin America board member
> Free Software Evangelist ? ? ?Red Hat Brazil Compiler Engineer
>
>