This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch c,c++,i386]:PR/15774 - Conflicting function decls not diagnosed


On Wed, 22 Dec 2010, Kai Tietz wrote:

> As this patch fixes a bug (as describe in the PR) in diagnostic output

I see nothing in PR 15774 that is relevant to this patch or the bug you 
now describe.  Have you given the wrong PR number?  That PR is, again, 
"Conflicting function decls not diagnosed".  It's not about bad or 
confusing diagnostics; it's about missing diagnostics.

> t.c:2:5: note: expected 'int (*)(void)' but argument is of type 'int (*)(void)'

That's a bug, but not 15774.  Please try again, resubmitting the patch 
under an accurate subject with more attention to writing it up accurately; 
every hour you spend on writing up patches carefully and accurately saves 
much more time for hundreds of readers.

You don't appear to have addressed my point that there should be one and 
only one point in the x86 back end that knows the list of ABI attributes; 
not duplicate lists in your new hook and in ix86_comp_type_attributes.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]