This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR middle-end/45310


On Sat, Dec 18, 2010 at 9:44 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Fri, Dec 17, 2010 at 5:22 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> Hello,
>>
>> When removing a statement, we should be removing it completely.
>>
>> Bootstrapped and tested on ia64-unknown-linux-gnu. OK for trunk?
>
> Ick. ?This means we also have to purge dead eh edges on the basic-block
> and then run cfgcleanup if we did. ?Similar adjustment needs to be
> done a few lines below, we need to call maybe_clean_eh_stmt on
> the modified stmt (and also cleanup dead eh edges).
>
> The patch is ok as-is if you don't want to bother with all the above
> corner-cases now (but it's probably not too difficult to construct other
> similar testcases ;))

I'll commit as-is because, quite frankly, I have no idea how this code works :-)

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]