Re: [pr46489-20101217-branch]: hookize INIT_CUMULATIVE_*ARGS, CALL_POPS_ARGS

[Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>]

Hi Joern,

a couple of nits:

* Joern Rennecke wrote on Sun, Dec 19, 2010 at 03:06:43PM CET:
> --- target.def	(revision 167989)
> +++ target.def	(working copy)
> @@ -1922,6 +1922,31 @@ HOOK_VECTOR (TARGET_CALLS, calls)
>   bool, (const_tree type),
>   hook_bool_const_tree_false)
>  
> +DEFHOOKPOD
> +(cumulative_args_size,
> + "The amount of memory, in bytes, that the caller should allocate when\
> + passing a non-@code{NULL} @var{mem} argument to the\
> + @code{init_cumulative_args} target hook.",
> +/* Once we  got all the  struct-user ports fully hookized, we can use
> +   sizeof(int) as  default.  */
> + const size_t, sizeof (CUMULATIVE_ARGS))
> +
> +DEFHOOK
> +(init_cumulative_args,
> + /* Still waiting on the FSF to allow us to put the full documentation here.  */
> + "Broadly like @code{INIT_CUMULATIVE_ARGS}, but it's a hook.\
> +  @var{mem} is a memory area to accomodate the target-specific data referred\

accommodate

> +  to by a cumulative_args_t.  It should be (at least) of the size that\

@code{cumulative_args_t} ?

> +  @code{TARGET_CUMULATIVE_ARGS_SIZE} indicates.\
> +  If @var{mem} is NULL, a statically allocated memory area is used.\
> +  When @var{libname} is set, @var{fntype} contains a type which is not\
> +  necessarily the actual return type, but which has the same machine mode.\
> +  The return value is a @code{cumulative_args_t} that refers to the\
> +  initialized argument information.",
> + cumulative_args_t,

Cheers,
Ralf