This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Speedup copy_reference_ops_from_ref
On Wed, 8 Dec 2010, Joseph S. Myers wrote:
> On Wed, 8 Dec 2010, Richard Guenther wrote:
>
> > + BITS_PER_UNIT == 8
> > + ? 3 : exact_log2 (BITS_PER_UNIT),
>
> I know we use this idiom elsewhere, but if we (i.e. 3.4-or-later host
> compiler) aren't folding exact_log2 (BITS_PER_UNIT) to a constant (given
> constant BITS_PER_UNIT) there's something wrong with either our constant
> folding for built-in functions or our inlining heuristics.
I think we indeed should fold it to a constant. An even better
cleanup would be to introduce double_int_units_to_bits,
double_int_bits_to_units.
Richard.