This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3, libgomp, build] Don't use undefined symvers_renaming in configure

On 12/06/2010 05:56 PM, Rainer Orth wrote: 
I noticed that on mips-sgi-irix6.5, libgomp and libstdc++-v3 configure
would complain

test: argument expected

since symvers_renaming could be used uninitialized.  The following
trivial patch fixes this.

Bootstrapped without regressions on mips-sgi-irix6.5, ok for mainline?

Thanks.
	Rainer


2010-12-01 Rainer Orth<ro@CeBiTec.Uni-Bielefeld.DE>

	libgomp:
	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
	* configure: Regenerate.

	libstdc++-v3:
	* acinclude.m4 (symvers_renaming): Also set if enable_symvers = no.
	* configure: Regenerate.

diff -r 13f6c22ee782 libgomp/acinclude.m4
--- a/libgomp/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
+++ b/libgomp/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
@@ -358,6 +358,8 @@
           [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
         symvers_renaming=yes ;;
      esac
+else
+    symvers_renaming=no
  fi
  AM_CONDITIONAL(LIBGOMP_BUILD_VERSIONED_SHLIB_SOL2, test $symvers_renaming = no)
  ])
diff -r 13f6c22ee782 libstdc++-v3/acinclude.m4
--- a/libstdc++-v3/acinclude.m4	Wed Dec 01 13:35:11 2010 +0100
+++ b/libstdc++-v3/acinclude.m4	Wed Dec 01 13:47:04 2010 +0100
@@ -3004,6 +3004,8 @@
           [Define to 1 if the target runtime linker supports binding the same symbol to different versions.])
         symvers_renaming=yes  ;;
      esac
+else
+    symvers_renaming=no
  fi
  GLIBCXX_CONDITIONAL(ENABLE_SYMVERS_SOL2, test $symvers_renaming = no)




Ok.

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]