This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite, ada, build] Allow for further differences in type output in run_acats
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Arnaud Charlet <charlet at adacore dot com>, Paolo Bonzini <bonzini at gnu dot org>
- Date: Thu, 02 Dec 2010 19:35:51 +0100
- Subject: Re: [testsuite, ada, build] Allow for further differences in type output in run_acats
- References: <yddipzd1riv.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <20101202073923.GE14720@gmx.de>
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
> * Rainer Orth wrote on Wed, Dec 01, 2010 at 03:44:56PM CET:
>> I've just noticed that the ACATS tests weren't run on IRIX 6.5 with
>> /bin/ksh as CONFIG_SHELL. It turned out that the which() shell function
>> in ada/acats/run_acats still isn't robust enough. type -p gnatchop
>> would e.g. print
>
> Why don't you simply use the code which Autoconf provides for
> AC_CHECK_PROG or AC_PATH_PROG? Portable, stable, time-tested.
You'd probably have to ask the author of the original shell-based ACATS
testsuite. IMO the whole thing is so riddled with problems (both
portability and functionality, like no multilib support and copying the
whole testsuite into the build tree for every parallel invocation) that
any time spent improving it in its current form is wasted ;-(
I see absolutely no reason to have a non-Dejagnu based testsuite in
tree; this only creates integration problems of all sorts. Given that
we have the gnat.dg testsuite now, it shouldn't be too hard to extend
that to ACATS.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University