This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ObjC/ObjC++: bug fixes for @catch


> I don't really care, with the exception of parallelization - the ObjC testsuite
> currently takes about 100 seconds to run serially on my machine and I'd love to 
> parallelize it and cut that time down by 4x or so.

> See check_gcc_parallelize and lang_checks_parallelized in Makefile.in.  You'll need
> to set lang_checks_parallelized in objc/Make-lang.in.

Thanks

I played with that, and got to parallelize the checks with '-j2'.  On my 2-core machine the time 
to run the ObjC testsuite goes down from 1m45s to 57s when using '-j2' and executing the execute.exp
tests in parallel with the other ones (execute.exp itself takes 55 seconds so it's about the
best you can do with 2 cores).  It's good, but it's tuned only for '-j2' and the output is not too
great.  I wish DejaGNU was parallelizing the tests for us; it would be able to adapt much
better to changes in the argument of '-j', and could produce a nice report, identical
to the standard one.

Anyway, good enough for now.  A patch is attached below.

Ok to commit ?

Thanks

Index: Make-lang.in
===================================================================
--- Make-lang.in        (revision 167262)
+++ Make-lang.in        (working copy)
@@ -104,6 +104,12 @@
 
 lang_checks += check-objc
 
+# The following allows you to do 'make check-objc -j2'.  The
+# execute.exp tests will be run in parallel with all the other ones.
+# This is tuned for '-j2'.
+lang_checks_parallelized += check-objc
+check_objc_parallelize = execute.exp
+
 #

 # Install hooks:
 # cc1obj is installed elsewhere as part of $(COMPILERS).
Index: ChangeLog
===================================================================
--- ChangeLog   (revision 167262)
+++ ChangeLog   (working copy)
@@ -1,5 +1,12 @@
 2010-11-29  Nicola Pero  <nicola.pero@meta-innovation.com>
+           Mike Stump  <mikestump@comcast.net>
 
+       Allow 'make check-objc -j2'
+       * Make-lang.in (lang_checks_parallelized): New.
+       (check_objc_parallelize): New.
+
+2010-11-29  Nicola Pero  <nicola.pero@meta-innovation.com>
+
        * objc-act.c (objc_eh_runtime_type): Avoid ICE if error_mark_node
        is passed as argument.
        (objc_begin_catch_clause): Added code to deal with an



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]