This is the mail archive of the
mailing list for the GCC project.
Re: [trans-mem] PR46653: handle identical log entries in hash
On 11/29/10 09:51, Richard Guenther wrote:
On Mon, Nov 29, 2010 at 3:39 PM, Aldy Hernandez<firstname.lastname@example.org> wrote:
But that'll still treat s.a and s.a as different when s is volatile.
operand_equal_p() will return false for volatiles, even if they are exactly
the same pointer because of the side-effects. This causes problems when
we search for an existing hash slot, because we never match ourselves.
OK for branch?
What do you mean? The whole point of the patch is to treat them the
same regardless of the volatile specifier.
For that matter, I think we could get away with just using pointer
equality for the TM log hash equality function (though probably not for
the TM memory optimization pass).