This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch Darwin] Fix PRs 33120, 35710, 26427


On Nov 27, 2010, at 4:35 AM, IainS wrote:
> This patch, based in part on Mike's comment #10 in PR33120, is a re-write of Darwin's zeroed-storage allocators.

And more...

>  static section *
>  darwin_mergeable_string_section (tree exp,
>  				 unsigned HOST_WIDE_INT align)
>  {
> +
>    if (flag_merge_constants
>        && TREE_CODE (exp) == STRING_CST
>        && TREE_CODE (TREE_TYPE (exp)) == ARRAY_TYPE

No blank line here.

> +      /* The align must be honoured, even for zero-sized.  */

Spelling, honored.

> OK for trunk?

Ok with those changes.

A patch of this size and with as many bits in it as this one has, makes me a bit nervous.  Please watch for any fall out.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]