This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR46664
- From: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Zdenek Dvorak <ook at ucw dot cz>
- Date: Fri, 26 Nov 2010 12:46:19 +0100
- Subject: Re: [PATCH] Fix PR46664
- References: <alpine.LNX.2.00.1011261226170.23074@zhemvz.fhfr.qr>
Hi,
> When aff_combination_add overflows MAX_AFF_ELTS it appends to ->rest
> and for pointer typed combination does so in sizetype. This shows
> an inconsistency wrt aff_combination_to_tree which starts with ->rest,
> adding to a non-pointer even for pointer typed combinations.
>
> It seems more natural to add ->rest last and assume that the first
> element of the combination will be the pointer base. Starting with
> ->rest was probably done for efficiency reasons, not for code quality
> or consistency with something else?
no, there was no reason other than making the code of aff_combination_to_tree
two lines shorter :-)
Zdenek