This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Review of --enable-gold=both patch

On Tue, Nov 23, 2010 at 9:09 AM, H.J. Lu <> wrote:
> On Tue, Nov 23, 2010 at 5:26 AM, Matthias Klose <> wrote:
>> On 23.11.2010 13:24, Nick Clifton wrote:
>>> Hi Matthias,
>>> [Sorry about the delay in replying - I am in a bit of a muddle right now].
>>>> The attached patch implements this proposal, tested the combinations
>>>> above, and disabling ld without gold (leading to an error).
>>>> I did choose to always install the bfd linker as ld.bfd and the gold
>>>> linker as, and pointing the link to one of the above.
>>>> Nick, is this ok with you?
>>> Yes, it is fine. Thanks for doing this.
>> checked in in gcc as r167076. ?Nick, Tristan, could you check it into
>> binutils trunk and branch?
> Binutils is broken now:

This change:

case "${ENABLE_LD}" in
    if test x${default_ld} != xgold; then
      AC_MSG_ERROR([either gold or ld can be the default ld])

is wrong.  At this time, default_ld is set to gold only by --enable-gold=default
What we should test is

if test x${default_ld} != x; then

which checks that default_ld isn't set.  Also comments are wrong:

# Handle --enable-gold, --enable-ld.
# --disable-gold [--enable-ld]
#     Build only ld.  Default option.
# --enable-gold[=default] [--enable-ld]
#     Build both gold and ld.  Install gold as "" and "ld",
#     install ld as "ld.bfd".

 --enable-gold only enables gold, not make it default unless
ld is disabled.

# --enable-gold[=default] --disable-ld
#     Build only gold, which is then installed as both "" and "ld".
# --enable-gold --enable-ld=default
#     Build both gold (installed as "gold") and ld (installed as "ld").

gold is installed as  ld is also installed ld.bfd.

#     In other words, ld is default
# --enable-gold=default --enable-ld=default
#     Error.

I am checking in this patch as an obvious fix.

2010-11-23  H.J. Lu  <>

	PR binutils/12258
	* Correct comments for --enable-gold/--enable-ld.
	Properly check default linker.
	* configure: Regnerated.

Attachment: binutils-pr12258-1.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]