This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target


On 19/11/2010 02:20, Mike Stump wrote:
> On Nov 18, 2010, at 5:15 PM, Joseph S. Myers wrote:
>> I think we should just enable HANDLE_PRAGMA_PACK_PUSH_POP unconditionally.  
>> That eliminates a target macro - one used in front ends, where we would 
>> particularly like to eliminate them - and simplifies the testsuite (no 
>> need for tests of this pragma to be conditional), as well as improving 
>> portability of code between supported targets; I don't see any reason to 
>> restrict this feature to some targets only.  This in turn obsoletes 
>> HANDLE_SYSV_PRAGMA as well (the documentation claiming it also affects 
>> #pragma weak is wrong), so two target macros can die.
> 
> I endorse this as well.

  Thirded!

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]