This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix -flto=N parsing

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Andrew Pinski <pinskia at gmail dot com>
Cc: Richard Guenther <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
Date: Thu, 18 Nov 2010 22:30:39 +0000 (UTC)
Subject: Re: [PATCH] Fix -flto=N parsing
References: <alpine.LNX.2.00.1011181214230.23074@zhemvz.fhfr.qr> <AANLkTimySRDBjD7Xz=vu6drqtjw3KMt06H1qaG+q7LPW@mail.gmail.com>

On Thu, 18 Nov 2010, Andrew Pinski wrote:

> On Thu, Nov 18, 2010 at 3:17 AM, Richard Guenther <rguenther@suse.de> wrote:
> >
> > This fixes an oversight when doing s/-fwhopr/-flto/, the character
> > index of =N parsing didn't get updated.
> > ! Â Â Â Â Â Â Â Â Â parallel = atoi (option + 6);
> 
> Should we be using atoi here?  I think we should use strtol instead
> and check for errors in decoding of the number.

Use of atoi in GCC (in general) is PR 44574.  If we fix the existing cases 
we could poison it in system.h.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] Fix -flto=N parsing
  - From: Richard Guenther
- Re: [PATCH] Fix -flto=N parsing
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]