This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH for PR/39415 (type of static_cast<cv Derived*>(Base*))

On Fri, Nov 12, 2010 at 6:06 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Additional clues from others are very welcome.
>
> A few nits: 1) cp/ has its own ChangeLog so the entry should be put there
> (without the cp/ prefix). ?2) You need to put the component in the PR
> reference, otherwise it doesn't serve any useful purpose. ?3) Blank line
> after you name. ?4) You need to write an entry for testsuite/ as well.

Thanks for the review.  I applied the changes you suggested, but not
as quickly as Jason did.  Who knows, next time I might get it right
(or more nearly so) the first time.  On the bright side, this buglet
that's been lurking for years is now fixed at head, and I'm a little
more clued up on how to prepare patches for GCC.

-- James
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]