This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix typo of the comment in resource.h


2010/11/15 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 15/11/2010 05:11, Mingjie Xing wrote:
>> Hi
>>
>> This small patch fix the typo of the comment in resource.h. Is it OK?
>
> ?I cannot approve the patch, but spotted an additional grammar problem that
> you could fix at the same time:
>
> - ?char unch_memory; ? ?/* Insn sets of needs a "unchanging" MEM. ?*/
> + ?char unch_memory; ? ?/* Insn sets or needs a "unchanging" MEM. ?*/
>
> ?It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
>
> ? ?cheers,
> ? ? ?DaveK
>

Indeed. Updated the patch. Thanks.

Mingjie,

Index: resource.h
===================================================================
--- resource.h  (revision 163986)
+++ resource.h  (working copy)
@@ -33,7 +33,7 @@ along with GCC; see the file COPYING3.
 struct resources
 {
   char memory;         /* Insn sets or needs a memory location.  */
-  char unch_memory;    /* Insn sets of needs a "unchanging" MEM.  */
+  char unch_memory;    /* Insn sets or needs an "unchanging" MEM.  */
   char volatil;                /* Insn sets or needs a volatile memory loc.  */
   char cc;             /* Insn sets or needs the condition codes.  */
   HARD_REG_SET regs;   /* Which registers are set or needed.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]