Re: [PATCH] Remove warning while compiling with CLooG isl

[Tobias Grosser <grosser at fim dot uni-passau dot de>]

On 11/12/2010 02:37 PM, Jack Howarth wrote:
> On Fri, Nov 12, 2010 at 11:30:34AM -0500, Tobias Grosser wrote:
> > Hi,
> >
> > this patch fixes a warning that appears when compiling graphite with
> > CLooG isl.
> >
> >          * graphite-cloog-util.c (oppose_constraint,
> >          cloog_matrix_to_ppl_constraint,
> >          new_Constraint_System_from_Cloog_Matrix): Explicitly cast to int
> >          as CLooG isl uses unsigned integers. This triggered a warning.
> >
> > @Jack: This patch should fix the compile failure with CLooG isl. Can you
> > verify this?
>
> Tobi,
>     I can confirm that this patch allows gcc trunk to bootstrap on x86_64-apple-darwin10
> with ppl 0.15.9 and cloog.org git built as cloog-isl. Also..
>
> make -k check RUNTESTFLAGS="graphite.exp --target_board=unix'{-m32,-m64}'"
>
> shows no regressions.
>           Jack

Great. Thanks for testing.

> ps Are there any instructions for building cloog-ppl from cloog.org git? I would like to
> test gcc trunk against that instead of legacy cloog's ppl support. I assume that cloog.org's
> cloog-ppl might require ppl 0.11, no?

No. ;-)

I believe this is how it should work:

git clone  git://repo.or.cz/cloog-parma.git
cd cloog-parma
./get_submodules.sh
./autogen.sh
./configure
make
make check

However this one is not as well tested as cloog-isl. I believe it should 
bootstrap, but I did not verify this recently.

Cheers
Tobi