This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH RFA: build machinery: Add Go support to libtool


Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> * Ian Lance Taylor wrote on Wed, Nov 03, 2010 at 09:31:27PM CET:
>> This patch, similar to the one I just sent for config/go.m4, adds Go
>> support to libtool.  This is not used by anything at present, but will
>> be used by libgo when it is committed.  I have proposed a similar patch
>> to the libtool maintainers.  When gcc includes a version of libtool with
>> support for Go, this patch can go away.
>> 
>> Bootstrapped on x86_64-unknown-linux-gnu.  OK for mainline?
>
> This patch is lacking a ChangeLog entry.
>
> Did you ensure that none of the configure scripts (nor aclocal.m4 files)
> in mainline change when the patch is applied (even when
> --enable-maintainer-mode is used)?

Good point.  It does change them.  It adds

m4_include([../config/go.m4])

to acinclude.m4 and adds the corresponding code to configure.

This makes me think that I am on the wrong path here.  I think I will
try to move this change and go.m4 into libgo itself, and then just fix
up libgo when gcc moves to sufficiently new versions of autoconf and
libtool.  That will confine the version skew issues to a single
directory.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]