This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Group static constructors and destructors in specific subsections, take 2


On Thu, Nov 11, 2010 at 02:57:02AM +0000, Dave Korn wrote:
> On 11/11/2010 01:15, Jack Howarth wrote:
> > On Wed, Nov 10, 2010 at 11:56:18PM +0100, Jan Hubicka wrote:
> >>> that I pruned off of it. If I revert your patch and repeat the build,
> >>> the error disappears. It is unclear to me what section in the remainder
> >>> of the patch could be causing this problem.
> >> It is the tm.texi being build from tm.texi.in just revert both doc
> >> directory changes and you should be safe.
> >> 
> >> Thanks, Honza
> > 
> > Honza, The problem is that you can't avoid making the texi changes.
> 
>   Yes you can.  Just start with a fresh build dir, a clean source tree, and
> discard the entire tm.texi hunk from Honza's patch, which was most likely
> inadvertent since it's not mentioned in the changelog.

Dave,
   No, I did that. Starting from a fresh source tree and using all of the
patch except for the first hunk gcc/doc/tm.texi (which I deleted manually
from the patch before applying), the failure still occurs. Something in the
build triggers the generation of the same exact lines which were omitted
manually from the patch. Believe me I tried this four or five times to
verify the behavior exists.
                 Jack

> 
> > Without
> > the doc/tm.texi section of your patch applied, the build actually ends up
> > recreating it in the build directory and then demands that the change be
> > moved over into the source tree's gcc/doc/tm.texi.
> 
>   Not if $srcdir/gcc/doc/tm.texi.in is clean.
> 
>     cheers,
>       DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]